#19930: A proper class for Hamming codes
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/hamming_code              |  3b48dcb4a7a10e578dfa5ae277191dafcece83ff
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'David Lucas', 'oldvalue': ''}):

 * status:  new => needs_review
 * commit:   => 3b48dcb4a7a10e578dfa5ae277191dafcece83ff
 * author:   => David Lucas


Comment:

 I pushed the patch, this is now open for review.

 Alongside with the new classes, I also made the (very small) following
 changes:

 - an `isinstance` test in `codecan/autgroup_can_label.pyx` was based on
 the old API and thus was only working with instances of class
 `LinearCode`. I changed it so it works now with any linear code, specific
 code families included.

 - the method `__cmp__` in `AbstractLinearCode` was quite useless (imho),
 so I removed it.

 David
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=25707e7e862f8e44330a878423206c8657f31711
 25707e7]||{{{Cleaned up index of modules}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4bb269adc963b5bcd55f590ffd22dcc3eee88cb5
 4bb269a]||{{{Merge branch 'cleanup_index_coding' into hamming_code}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c8c9cc97bf3bcd01a8c785fe28fa399b3ee59c13
 c8c9cc9]||{{{Added a new encoder based on parity check matrix}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=23c12cba66ef12a3a7a9351981564a0038d68f09
 23c12cb]||{{{New class for Hamming codes}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c92e42c5da7fcbb166274fb4292ca759fad9facb
 c92e42c]||{{{Fixed broken doctests in codecan folder, and changed an old
 insinstance test}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3b48dcb4a7a10e578dfa5ae277191dafcece83ff
 3b48dcb]||{{{Fixed broken doctests, removed __cmp__ method}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19930#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to