#19941: Rename rings.finite_rings.constructor to finite_field_constructor
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-7.1
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Dima Pasechnik
finite rings | Work issues:
Keywords: | Commit:
Authors: | 0bc4fc75c99ea6f968e2c72fd71fd33157ed5dd9
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/19941 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by dimpase):
* status: needs_review => positive_review
* reviewer: => Dima Pasechnik
Comment:
Replying to [comment:7 davidloeffler]:
> Nathann: You are out of order, and your comments on this ticket and the
associated sage_devel thread fall far below the standard of conduct
appropriate for Sage contributors.
>
> David Roe is one of Sage's most valued developers and he has worked
tirelessly on Sage's code for finite and p-adic fields.
David, FYI, Nathann just as well has been contributing to Sage quite a
bit.
> You, on the other hand, clearly know nothing about the content of this
file,
David, let me assure you that Nathann certainly perfectly aware of what a
finite field is. He has been using them quite a bit...
> and thus you are reduced to making aggressive, mocking comments about
its name, which is invisible to most Sage users anyway. You may as well
write to the authors of a paper in a top journal telling them that you
don't like the title they've given their paper.
>
There is quite a bit of crap in top journals, as we all know, often due to
reviewers...
Thanks goodness, here we can correct things overlooked by Sage reviewers.
This is often thankless job, but it makes code much more readable. And
this is very important.
> Don't you have anything better to do with your time?
Improving Sage codebase is very important, and we should be thankful to
Nathann for this.
--
Ticket URL: <http://trac.sagemath.org/ticket/19941#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
