#19521: wrong inverse action when using ConstructionFunctor.coercion_reversed
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Daniel Krenn | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/behackl/coercion/inverse-action | 867d6d3cc606f4c291bc9098e490366160b40f42
Dependencies: #19259 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dkrenn):
Replying to [comment:6 behackl]:
> Hi! I've merged the (positively reviewed) dependency into this branch
and reviewed the code in this ticket.
Thanks.
> In principle, all that happens is that you order the functors and
parents from smallest to largest (in the sense of coercion) and iterate
over this reordered tower such that actually the smallest parent with the
required property is found?
>
> For example, (using your notation from the comment), if we had a tower
`A -> B <- C <- D -> E`, then the old code would iterate over `[A, B, C,
D, E, F]`, and in your fixed version we iterate over `[A, D, C, B, E]`?
Correct.
> Also, I'd like to give the patchbots a chance to test this---or, at
least, run `make ptestlong` myself.
Ok.
--
Ticket URL: <http://trac.sagemath.org/ticket/19521#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
