#19870: Cythonize matrix group elements
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: cython | Resolution:
Keywords: matrix group, | Merged in:
elements | Reviewers:
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5333b0f2c69a99623c43c2f660d7441a9de23a6d
public/groups/cythonize_matrix_group_element-19870| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* milestone: sage-7.0 => sage-7.1
Comment:
Replying to [comment:13 jdemeyer]:
> 1. I think you should add a `.pxd` file such that other Cython modules
can `cimport` this if needed.
>
> 2. Use the standard
[http://doc.sagemath.org/html/en/developer/coding_basics.html#headings-of-
sage-library-code-files copyright template].
>
> 3. Remove `__cmp__ = _cmp_` twice (it doesn't work and it's not needed).
>
> 4. You don't actually use this: `from sage.structure.element import
have_same_parent`.
>
> 5. There is not much point in making `matrix()` a `cpdef` method: you
can just directly access the `_matrix` attribute from Cython.
All done. I also made `_matrix` a public attribute since doing access that
way was fastest way to access the defining matrix by my testing.
--
Ticket URL: <http://trac.sagemath.org/ticket/19870#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
