#19891: improve coding style and documentation in projective schemes
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_work
Priority: trivial | Milestone: sage-7.0
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Frédéric Chapoton,
Authors: Ben Hutz | Rebecca Lauren Miller, Joseph
Report Upstream: N/A | Eisner
Branch: | Work issues:
u/bhutz/ticket/19891 | Commit:
Dependencies: | 24a7f72b936648d2fdc02941022bed78772d72d8
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by eisnerj):
* reviewer: Frédéric Chapoton, Rebecca Lauren Miller => Frédéric Chapoton,
Rebecca Lauren Miller, Joseph Eisner
Comment:
Verify you meant to remove the dehomogenize step:
@@ -372,31 +372,30 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
Should these two errors match?:
@@ -2271,13 +2284,13 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
Check line breaks:
@ -413,8 +415,10 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -850,9 +857,11 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
Grammar:
@@ -1501,8 +1514,10 @@ class
SchemeMorphism_point_projective_field(SchemeMorphism_point_projective_ring
@@ -280,15 +280,16 @@ def
automorphism_group_QQ_fixedpoints(rational_function, return_functions =
Fals
Remove reference to self:
@@ -2659,16 +2680,18 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -3567,11 +3596,11 @@ class
SchemeMorphism_polynomial_projective_space_field(SchemeMorphism_polynomial
@@ -973,7 +989,7 @@ class ProjectiveSpace_field(ProjectiveSpace_ring):
Make references hyperlinks:
@@ -4249,10 +4289,14 @@ class
SchemeMorphism_polynomial_projective_space_finite_field(SchemeMorphism_pol
@@ -4291,14 +4335,15 @@ class
SchemeMorphism_polynomial_projective_space_finite_field(SchemeMorphism_pol
@@ -2391,37 +2406,38 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -2360,8 +2374,9 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
Spacing Issues:
@@ -765,7 +764,7 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -803,16 +802,16 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -833,7 +832,7 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -4129,9 +4166,9 @@ class
SchemeMorphism_polynomial_projective_space_finite_field(SchemeMorphism_pol
@@ -4159,7 +4199,7 @@ class
SchemeMorphism_polynomial_projective_space_finite_field(SchemeMorphism_pol
@@ -45,9 +44,9 @@ def _fast_possible_periods(self,return_points=False):
@@ -102,59 +101,59 @@ def
_fast_possible_periods(self,return_points=False):
@@ -182,58 +182,58 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -246,20 +246,20 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -293,58 +293,58 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -3010,12 +3039,14 @@ class
SchemeMorphism_polynomial_projective_space(SchemeMorphism_polynomial):
@@ -565,53 +569,54 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -742,16 +749,16 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -759,8 +766,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -813,9 +820,9 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -882,20 +891,20 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -903,12 +912,12 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1064,8 +1075,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1075,8 +1086,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1085,8 +1096,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1176,14 +1187,14 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1228,26 +1239,26 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1262,30 +1273,31 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1359,7 +1372,7 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1368,10 +1381,10 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1395,8 +1408,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1406,7 +1419,7 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1414,8 +1427,8 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
@@ -1424,24 +1437,24 @@ class
SchemeMorphism_point_projective_ring(SchemeMorphism_point):
--
Ticket URL: <http://trac.sagemath.org/ticket/19891#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
