#7012: [with patch, needs review] clean up sage/numerical/mip.pyx
------------------------------------------+---------------------------------
Reporter: mvngu | Owner: jkantor
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: numerical | Keywords:
Reviewer: Mike Hansen, Minh Van Nguyen | Author:
Merged: |
------------------------------------------+---------------------------------
Changes (by mvngu):
* reviewer: => Mike Hansen, Minh Van Nguyen
Comment:
I have uploaded a reviewer patch that makes the following changes (see
`trac_7012-reviewer.patch`):
1. Consistent use of double quotation marks in `sage/numerical/mip.pyx`.
1. Doesn't use trailing white spaces.
1. Limit the line width to about 75 characters. Don't go over 75 or so
characters per line if you don't need to.
1. Some typo fixes.
1. Add `sage/numerical/mip.pyx` to the reference manual.
1. Use 4-space indentation.
1. Proper ReST formatting so the module appears nicely when rendered.
1. Use `ValueError` instead of `Exception`. `ValueError` is more
explicit, whereas `Exception` would catch anything.
1. Use `maximization` with boolean values, instead of `sense` with either
1 or -1. This was suggested by Mike Hansen on IRC. So I would credit Mike
and myself as reviewers for this ticket.
Now my patch needs some reviewing by anyone other than me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7012#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
