#17287: K.is_subring(K) not implemented for some fields K
-------------------------------------+-------------------------------------
       Reporter:  mjo                |        Owner:  tmonteil
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  beginner           |    Merged in:
        Authors:  Akshay Ajagekar    |    Reviewers:  Michael Orlitzky,
Report Upstream:  N/A                |  Thierry Monteil
         Branch:                     |  Work issues:
  u/ajagekar.akshay/Trac17287        |       Commit:
   Dependencies:                     |  9c4d682482208d62144a6ffacf97786e214fcc44
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mjo):

 Looks good, thanks! I have one more nitpick.

 In the docstrings, the double-colons are used to indicate that "the thing
 after this is a test." So you will see,

 {{{
 EXAMPLES::

     sage: ZZ.is_subring(QQ)
     True
 }}}

 and

 {{{

 TESTS:

 Blah blah blah::

     sage: x == x
     True
 }}}

 but in the second case, the "TESTS:" doesn't need two trailing colons.

 Finally, these two lines can probably go:

 {{{
 sage: R
 Univariate Polynomial Ring in x over Real Field with 53 bits of precision
 }}}

 They don't really test anything useful. I think I included them in the
 description just to demonstrate that `R` is a ring.

--
Ticket URL: <http://trac.sagemath.org/ticket/17287#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to