#19897: Rewriting introductory thematic tutorial on coding theory
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/introductory_thematic_tutorial|  
4035292690854841fb19f3ce699dfa8fb2aacd51
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by saraedum):

 Looks very good to me. Some minor technical issues.
 * Typo in `Lets us now go a bit more into details on specific points.`
 * `The algorithms behind decoder work differently for each decoder:`
 sounds strange. Did you mean `Decoder` or `decoders`?
 * `to compare decoders which work the same`. Did you mean something like
 `decoders which share properties`?
 * `In Section II, we briefly introduced the new Channel objects as a new
 way to put errors in a word.`. I think you should remove both occurences
 of `new`. Channels are maybe new right now but they won't be anymore at
 some point.
 * `We also introduced a useful shortcut for`. Was that "introduced" in the
 document? Did you mean "have"?

 Have you checked that this looks alright in the pdf output? I think you
 might have to escape `...` somehow or maybe you can just use a unicode
 `…`. Same goes for the dashes you use; maybe they are alright but you
 might want to double check.

 Other than that, feel free to set this to "positive review" once you
 adressed the above.

--
Ticket URL: <http://trac.sagemath.org/ticket/19897#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to