#19595: Implement a check that a hyperplane arrangement is free
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  geometry           |   Resolution:
       Keywords:  free, hyperplane   |    Merged in:
  arrangement                        |    Reviewers:  Miguel Marco
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  195bfbefce9bf0253f817e2034fbb53cc58e709f
  public/hyperplanes/check_free-19595|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by mmarco):

 * reviewer:   => Miguel Marco


Comment:

 In some point (either the methods of the arrangement class, or the auxilar
 functions they call) there should be a check that the arrangement is
 central. Otherwise all these algorithms might not make sense. Right now
 things might fail at the `to_symmetric_space` function, but a more
 informative error would be nice. I am adding it now.


 Otherwise, it looks good. Let me pass the testsuite and check that the
 documentation builds correctly, and, if you are ok with my corrections, we
 can call it a day.

 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=195bfbefce9bf0253f817e2034fbb53cc58e709f
 195bfbe]||{{{Minor reviewer changes}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19595#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to