#19991: improve dimension function for subschemes of projective products
-------------------------------------+-------------------------------------
       Reporter:  bhutz              |        Owner:  bhutz
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-7.1
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:                     |    Reviewers:  Grayson Jorgenson
        Authors:  Ben Hutz           |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  9bbeb1edb8ef70232cf4c35b9127c97d19891d56
  u/bhutz/ticket/19991               |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by gjorgenson):

 * reviewer:   => Grayson Jorgenson


Comment:

 Doctests pass and everything seems to be working properly. Just a few
 really minor things:

 In algebraic_scheme:
 - line 2738 - spacing with ' -1', should be ' - 1'
 - line 2759 - spacing around '='
 - line 2774 - make exception message lower case
 - line 2776 - parentheses around k not needed, can change (k) to k

--
Ticket URL: <http://trac.sagemath.org/ticket/19991#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to