#19985: Add is_partial_cube
-------------------------------------+-------------------------------------
       Reporter:  jaanos             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  graph theory       |   Resolution:
       Keywords:  graphs partial     |    Merged in:
  cubes                              |    Reviewers:
        Authors:  Janoš Vidali       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  6b81097bc80245f66a6d94f8596846d0e5a6df98
  u/jaanos/add_is_partial_cube       |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jmantysalo):

 I have no more comments.

 I did some tests, like testing that cartesian products of partial cubes
 are partial cubes, and found no errors.

 I read the code. It seems complicated due to nature of algorithm using
 bitwise operators. However, it has good comments inside.

 I am unsure if I can not put this to positive review. Nathann, how
 rigorously should a reviewer read the code?

--
Ticket URL: <http://trac.sagemath.org/ticket/19985#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to