#20009: string monoid class one not defined
-------------------------------------+-------------------------------------
       Reporter:  kcrisman           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.1
      Component:  algebra            |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Karan Desai        |    Reviewers:  Karl-Dieter Crisman,
Report Upstream:  N/A                |  Thierry Monteil
         Branch:                     |  Work issues:
  u/karandesai-96/string_monoid_class_one_not_defined|       Commit:
   Dependencies:                     |  546b6ad213c348da6529eb3a96769ef2f0c5b78a
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by karandesai-96):

 Replying to [comment:11 tmonteil]:
 Yes, you are correct, I now understand why creating it within one() itself
 is better.

 Also, I am new to development for Sage, I want to ask you whether you
 build Sage completely again to review my code ? Building Sage takes a lot
 of time on my laptop, how did you manage to test my code ?

 > Let me suggest not doing things unless you actually need it, since this
 make some noise in the source code. Also, since no other monoid has such
 an attribute, it is likely that if someone once needs something like that,
 she will create an attribute with another name higher in the hierarchy,
 and the information will be stored twice. I guess that if someone needs
 the identity element, she will just call self.one() since it is the
 standard notation for monoids within Sage.

--
Ticket URL: <http://trac.sagemath.org/ticket/20009#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to