#19944: asymptotic expansions: singularity analysis
-------------------------------------+-------------------------------------
       Reporter:  behackl            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Daniel Krenn
        Authors:  Benjamin Hackl,    |  Work issues:
  Clemens Heuberger                  |       Commit:
Report Upstream:  N/A                |  ad62c3185d95d1711feb65c33f6096d0662e5c84
         Branch:  u/dkrenn/asy       |     Stopgaps:
  /singularity-analysis-method       |
   Dependencies:  #19532, #19969,    |
  #19981                             |
-------------------------------------+-------------------------------------

Comment (by dkrenn):

 Thanks you for your rewrite; it is much better and cleaner now; I consider
 the code as positively reviewed. However, please cross-review my minor
 changes and the following two documentation issues should be discussed
 (both concerning the private `_singularity_analysis_`-mathods:

 1. Is `(1-z\zeta) \to 0` correct or should it be `(1-z/\zeta) \to 0`?
 Maybe using `z\to\zeta` instead of `(1-z/\zeta) \to 0`? (I don't have a
 strong preference for changing, but from an outside view, this would be
 easier to understand.

 2. Should it be mentioned that (in terms and growth groups) a variable
 (`_var_` of the parent) represents/equals `1 / (1-z/\zeta)` ?

--
Ticket URL: <http://trac.sagemath.org/ticket/19944#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to