#20075: rising_factorial and falling_factorial should accept Python integers
-------------------------+-------------------------------------------------
Reporter: | Owner:
egourgoulhon | Status: needs_work
Type: | Milestone: sage-7.1
defect | Resolution:
Priority: major | Merged in:
Component: basic | Reviewers:
arithmetic | Work issues:
Keywords: | Commit:
factorial | 23fb2b1857cdba07e431c0e7521490c12e857ff5
Authors: Eric | Stopgaps:
Gourgoulhon |
Report Upstream: N/A |
Branch: |
public/20075 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:11 egourgoulhon]:
> Replying to [comment:10 egourgoulhon]:
> > In the current code, there is no need to force `a` to be a Sage
element, for only `x.parent()` is invoked. So I would apply
`py_scalar_to_element` only to `x`. Do you agree?
>
> PS: in particular, the current code already works with `a` being a numpy
integer (I've just checked it).
Are you sure? What kind of numpy integers did you try?
{{{
sage: import numpy
sage: a = numpy.int8(10)
sage: b = numpy.int(5)
sage: isinstance(a, int)
False
sage: isinstance(b, int)
True
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/20075#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
