#20061: Add method for finding all perfect matchings to Graph
-------------------------------------+-------------------------------------
       Reporter:  egunawan           |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-7.1
      Component:  graph theory       |   Resolution:
       Keywords:  perfect matching,  |    Merged in:
  graph                              |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/egunawan/20061   |  da6befdeec141f05f665de5e5322752c2751f2ef
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello again,

 - You chose 'basic methods' for your new method but counting matchings is
 not basic at all. The `.matching` method, in particular, is in the
 'leftovers' section.

 - You can write a check of your method using the `matching_polynomial`
 methods which counts the number of matchings. It will also give you the
 number of perfect matchings.

 - Your method probably fails on a graph like
 `graphs.PetersenGraph().copy(immutable=True)`.

 - I discussed with Travis the advantages of checking (with `.matching()`)
 that the graph actually contains a perfect matching before recursing. Is
 there a reason why you decided against it ?

 - If you want to, you can optionally add SEEALSO sections to/from the
 other matching-related methods:
 http://doc.sagemath.org/html/en/developer/coding_basics.html
 #documentation-strings

 - Please set your ticket to `needs_review` when you are done with your
 changes and want somebody to look at your code.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/20061#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to