#19953: Add pictures to plot.py
-------------------------------------+-------------------------------------
Reporter: jhonrubia6 | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-7.1
Component: documentation | Resolution:
Keywords: plot,docstring | Merged in:
Authors: Javier Honrubia | Reviewers: Eric Gourgoulhon
Gonzalez | Work issues:
Report Upstream: N/A | Commit:
Branch: | 42b9e4ccb4cf7a5cc6c2f93f304359d34059e23d
u/jhonrubia6/add_pictures_to_plot_py| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by egourgoulhon):
* status: needs_review => positive_review
Comment:
Thanks for the changes. Everything seems fine. I've also checked that the
pdf doc produced with `./sage -docbuild reference/plotting pdf` is
correctly generated, with all the figures included.
Regarding the extra CPU time discussed in comment:9 to comment:15, it took
only 1 min 30 s to generate all the html plot section on my computer,
which seems acceptable, given the huge benefit of having nice figures in
the doc. So I suggest to leave the picture generation as the default and I
am setting a positive review. Thanks again for this work!
--
Ticket URL: <http://trac.sagemath.org/ticket/19953#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
