#18990: FiniteStateMachine: Incorrect string formatting in final_word_out setter
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_work
Priority: trivial | Milestone: sage-7.1
Component: finite state | Resolution:
machines | Merged in:
Keywords: beginner | Reviewers: Clemens Heuberger
Authors: | Work issues: author name
Report Upstream: N/A | Commit:
Branch: | e16ca2788133a0f7d711c02515d814d1209c2da3
u/cheuberg/finitestatemachine__incorrect_string_formatting_in_final_word_out_setter|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by cheuberg):
* status: needs_review => needs_work
* commit: 612d2b9c6cc9396deab349b8f69c1c6e4f8216a2 =>
e16ca2788133a0f7d711c02515d814d1209c2da3
* work_issues: => author name
* reviewer: => Clemens Heuberger
Comment:
Thanks.
I added two reviewer commits for PEP8 compliance.
Please add your full name in the author field of this ticket.
I do not know whether we have a strict policy on that, but most commits in
Sage nowadays have the ''full name'' of the author as the git author, see
the [http://doc.sagemath.org/html/en/developer/git_setup.html#your-name-
and-email developer's guide]. This would be impractical for these commits,
but please do it for future contributions.
Apart from that, this is a positive review from my side.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=fd811f31c7358cfcf0d62f3469f3d097ba84a34c
fd811f3]||{{{Trac #18990: PEP8-compliance: line lengths}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e16ca2788133a0f7d711c02515d814d1209c2da3
e16ca27]||{{{Trac #18990: PEP8-compliance: spacing}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18990#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
