#19457: Generator for full binary trees
-------------------------------------+-------------------------------------
Reporter: patxiku | Owner: patxiku
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: binary trees, | Merged in:
full | Reviewers: Travis Scrimshaw,
Authors: Adrien | Vincent Delecroix
Boussicault, Bérénice Delcroix- | Work issues:
Oger, Patxi Laborde-Zubieta | Commit:
Report Upstream: N/A | db680072fecf713753e1a9c1320477607408b940
Branch: | Stopgaps:
public/combinat/full_binary_trees-19457|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
* commit: e6b47af34b45ca5bfe40c67464e75f895cd71596 =>
db680072fecf713753e1a9c1320477607408b940
* branch: u/patxiku/generator_for_full_binary_trees =>
public/combinat/full_binary_trees-19457
* reviewer: => Travis Scrimshaw, Vincent Delecroix
Comment:
Okay, I have addressed my issues. I also fixed the facade parent issue for
all binary trees (not just full). I also renamed the
`remove_two`-something-a-rather into the more intuitive (and correct)
`prune()` as it removes ''all'' leaves from a given (not necessarily full)
tree. Vincent, if you agree with my changes, then please go ahead and set
a positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=9b1817ea4d1efa17c73a8abf0d3e64fd1a1dadd0
9b1817e]||{{{Merge branch 'u/patxiku/generator_for_full_binary_trees' of
trac.sagemath.org:sage into public/combinat/full_binary_trees-19457}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e1d460635b4b92a4a25e65be29def639f376c907
e1d4606]||{{{Some initial reviewer changes.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=db680072fecf713753e1a9c1320477607408b940
db68007]||{{{Converting to proper facade parents.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19457#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
