#19290: MatroidUnion _rank accept any iterator, partition accept empty partition
-------------------------------------+-------------------------------------
       Reporter:  chaoxu             |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  trivial            |    Milestone:  sage-6.9
      Component:  matroid theory     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Chao Xu            |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/chaoxu/matroid_union             |  4f501fbc5cdc0958d148bfe98b42a3a571a337e5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by Stefan):

 * status:  needs_review => needs_work


Comment:

 See
 
http://doc.sagemath.org/html/en/reference/matroids/sage/matroids/matroid.html#sage.matroids.matroid.Matroid
 for an explanation of what we normally assume about inputs to our
 underscored functions. I agree with Rudi in this case, it is the
 responsibility of the caller to provide something with set interface to
 _rank, not the responsibility of _rank.

 In addition, please keep your tickets to one issue per ticket: the
 PartitionMatroid fix is fine, but can't go in because of the first issue.

--
Ticket URL: <http://trac.sagemath.org/ticket/19290#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to