#19930: A proper class for Hamming codes
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/hamming_code              |  0dff97b48d12b6d2caf4917a20b6d51feca24b7d
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by cpernet):

 lines 156 to 161 of hamming_code.py: this code seems very odd to me. I do
 not see what you are trying to do here.
 - the two branches of the if then else block are identical.
 - The series of swaps being performed result in a cyclic rotation of the
 first m/2 rows and the last one. Is this really what is intended?

 If, as I presume, you're trying to simply flip the order of the rows,
 then, try something like
 {{{
 H = H[::-1,:]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/19930#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to