#20219: Remove redundant functions from gen.pyx
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: interfaces | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/remove_redundant_functions_from_gen_pyx|
0f2386ab32d486aca0a705c00d6da6965f24623e
Dependencies: #20210, #20205, | Stopgaps:
#20213, #20216, #20217 |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:16 jdemeyer]:
> Replying to [comment:10 vdelecroix]:
> > There was no doctest for `vecmin`, `vecmax`, `elltaniyama`,
`bnfcertify`, `bnfunit`, `idealval`, `nfsubfields`, .Would it be possible
to provide one to check that the methods exist?
>
> I don't see the point. We provide the functions exposed by PARI/GP. If
these functions are used in Sage library code, there is an implicit test
that they work. If they are not used, I don't see why it's our business to
check that PARI/GP has a `vecmin()` function for example.
But these functions used to be there. Some people might use them outside
of the Sage library code. I do not claim that the code was good from the
begining but that the changes should be as smooth as possible.
> > The methods `idealintersection`, ` reverse`, `order`, ` listinsert`,
`listput` were simply removed. You should provide deprecation and test it.
>
> `idealintersection` and `reverse` are tested in `tests.py`. The last
three indeed disappeared.
The same remark applies.
--
Ticket URL: <http://trac.sagemath.org/ticket/20219#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
