#20293: matrix constructor fails on numpy.matrix
-------------------------------------+-------------------------------------
       Reporter:  cnassau            |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  numerical          |   Resolution:
       Keywords:  numpy, matrix      |    Merged in:
        Authors:  Christian Nassau   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:  u/cnassau/numpy-   |       Commit:
  matrix-2                           |  02fb33195dffad7da19a5481aaade6253b8e3029
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by cnassau):

 Replying to [comment:5 jdemeyer]:
 > This is silly:
 > {{{
 > strncmp(t.__module__, "numpy", 5) == 0
 > }}}
 > Either you use Python or you use C, but I don't understand why this
 strange mixture. Anyway, I really want this check to be very fast, so we
 might need to think if we can make this more efficient.

 Here you go, the check has now been cythonized (by a non-cython programmer
 who just hopes that the refcounts work out alright).

--
Ticket URL: <http://trac.sagemath.org/ticket/20293#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to