#19123: LatticePoset: add is_vertically_decomposable
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  jmantysalo             |       Status:  needs_review
           Type:         |    Milestone:  sage-7.0
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:
  combinatorics          |  Work issues:
       Keywords:         |       Commit:
        Authors:  Jori   |  0ee8b96dbb37a87c5c43b4fd0ad6c7ee8c8a97c4
  Mäntysalo              |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/19123           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by kdilks):

 Minor grammatical corrections:

 * In {{{vertical_decomposition()}}}, 'Let `d_1, \ldots , d_n` be elements
 comparable to every element of the lattice, excluding the top and bottom
 elements.' Should be rephrased as 'Let `d_1, \ldots, d_n` be elements
 (excluding the top and bottom elements) comparable to every element of the
 lattice.' The original version makes it sound like the top and bottom
 elements are being excluded from the set of things that `d_1...d_n` need
 to be comparable to, instead of being excluded from the set `d_1...d_n`
 itself.


 * Immediately following that, 'Let `b` be THE bottom element and `t` be
 the top element.'

 * 'Informally said, this returns the lattice SPLIT INTO parts AT every
 single-element "cutting point".'

 * Under `INPUT:`, 'return the list OF decomposing elements'.

 * In the definition of {{{is_vertically_decomposable()}}}, 'A lattice is
 vertically decomposable if it has an element that is comparable to all
 elements and is NEITHER the bottom NOR the top element.'

 Besides that, I think I'm happy with it. I'll just need to check the
 rendered documentation once those changes are made.

--
Ticket URL: <http://trac.sagemath.org/ticket/19123#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to