#20254: Improvements on p-adic L-functions for elliptic curves
-------------------------------------+-------------------------------------
Reporter: wuthrich | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-7.2
Component: elliptic curves | Resolution:
Keywords: days71, p-adic | Merged in:
L-functions | Reviewers:
Authors: wuthrich | Work issues:
Report Upstream: N/A | Commit:
Branch: | a265fc0f458017a32e6a923b836901a8baaaf3c0
/u/wuthrich/ticket/20254 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by saraedum):
Some minor remarks:
* You added a few chunks of commented out code. These should be removed I
guess. If they can't then there should at least be a comment what they are
about.
* `_poly()` has no complete docstring (in particular no doctests)
Without understanding all the details, everything else seems alright. Feel
free to set to postitive review yourself once you adressed the above.
--
Ticket URL: <http://trac.sagemath.org/ticket/20254#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
