#19036: Use vectors instead of tuples in Polyomino
-------------------------+-------------------------------------------------
Reporter: | Owner:
vdelecroix | Status: needs_review
Type: | Milestone: sage-7.1
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Sébastien Labbé
combinatorics | Work issues:
Keywords: | Commit:
Authors: | fb8f324fa9e3cf16d22e3b91b8ee85e1f4aa6af9
Vincent Delecroix | Stopgaps:
Report Upstream: N/A |
Branch: |
public/19036 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by slabbe):
* status: needs_work => needs_review
* commit: 10f03e0cf2e11cf61785778d55c8a605d417a437 =>
fb8f324fa9e3cf16d22e3b91b8ee85e1f4aa6af9
* branch: u/vdelecroix/19036 => public/19036
* reviewer: => Sébastien Labbé
Comment:
I confirm this branch makes things faster:
BEFORE:
{{{
sage: from sage.games.quantumino import QuantuminoSolver
sage: q = QuantuminoSolver(0)
sage: %timeit L = q.tiling_solver().rows()
1 loop, best of 3: 7.26 s per loop
}}}
AFTER:
{{{
sage: from sage.games.quantumino import QuantuminoSolver
sage: q = QuantuminoSolver(0)
sage: %timeit L = q.tiling_solver().rows()
1 loop, best of 3: 1.78 s per loop
}}}
I fixed the long time doctests errors. To me this is a positive review. I
let Vincent change the status to positive review if he agrees with my
commit.
Note: I rebased the branch of Vincent on top of most recent development
version.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=22e1d1038558127bbe0af0b1d69af668db093fe5
22e1d10]||{{{Trac 19036: use vectors instead of tuples in polyomino}}}||
||[http://git.sagemath.org/sage.git/commit/?id=fb8f324fa9e3cf16d22e3b91b8ee85e1f4aa6af9
fb8f324]||{{{trac #19036: fixing long time doctests}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19036#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
