#20136: Various meataxe build issues
-------------------------------------------------+-------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.1
Component: packages: optional | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: Reported upstream. Developers | Work issues:
acknowledge bug. | Commit:
Branch: | Stopgaps:
Dependencies: |
-------------------------------------------------+-------------------------
Comment (by SimonKing):
The following should be a better idea for `spkg-src`:
- `git clone` upstream.
- `git checkout` the appropriate commit --- which is what one needs to
change for upgrading the sources.
- Apply the following general patch, that I will suggest to upstream:
{{{
#!diff
diff --git a/Makefile b/Makefile
index 935964b..49c2b86 100644
--- a/Makefile
+++ b/Makefile
@@ -221,7 +221,7 @@ tmp/test-%.done: tests/common.sh tests/%/run
$(PROGRAMS:%=${MTXBIN}/%)
@touch "$@"
-.PHONY: tar clean install test
+.PHONY: tar dist clean install test
.PRECIOUS: tmp/%.o
@@ -264,6 +264,8 @@ EXPORTED_FILES =\
Makefile README.md COPYING\
src/meataxe.doc src/changelog.doc\
+TESTS = tests
+
tar: all doc
rm -f meataxe-${MTXVERSION} meataxe-${MTXVERSION}.tar
meataxe-${MTXVERSION}.tar.gz \
&& ln -s . meataxe-${MTXVERSION} \
@@ -271,3 +273,11 @@ tar: all doc
&& rm meataxe-${MTXVERSION} \
&& gzip meataxe-${MTXVERSION}.tar \
&& echo "Created meataxe-${MTXVERSION}.tar.gz"
+
+dist: all doc
+ rm -f meataxe-${MTXVERSION} meataxe-${MTXVERSION}.tar
meataxe-${MTXVERSION}.tar.gz \
+ && ln -s . meataxe-${MTXVERSION} \
+ && tar cf meataxe-${MTXVERSION}.tar
$(EXPORTED_FILES:%=meataxe-${MTXVERSION}/%) meataxe-${MTXVERSION}/${TESTS}
\
+ && rm meataxe-${MTXVERSION} \
+ && gzip meataxe-${MTXVERSION}.tar \
+ && echo "Created meataxe-${MTXVERSION}.tar.gz including tests"
--
}}}
- Use `sed` to replace the word `-SNAPSHOT` in the Makefile by the current
commit hash. That will work, because the spkg-src script ''is'' in a git
repository at that point.
- When building the spkg, there will be no git repository. But now, the
commit number is hardcoded in the Makefile. The hardcoded number, however,
will change automatically when changing the choice of commit in spkg-src.
Question:
Is it acceptable to add a general spkg-src, that takes the chosen commit
of the upstream repository as an argument? In that way, one could obtain
meataxe-2.5.0.123456.tar.gz for commit 123456 simply by calling `spkg-src
123456`.
--
Ticket URL: <http://trac.sagemath.org/ticket/20136#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
