#20336: Add more features to mq.SBox
-------------------------------------+-------------------------------------
Reporter: ruhm | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: cryptography | Resolution:
Keywords: SBox, | Merged in:
cryptography | Reviewers: Travis Scrimshaw
Authors: Rusydi H. Makarim | Work issues:
Report Upstream: N/A | Commit:
Branch: | 38b627e25ee6525ec6ffd83d55ecbeea574ea155
u/ruhm/improved_sbox | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
Welcome to Sage! This is a very well-done submission.
Now that you are using `@cached_method`, you don't need the
`_autocorrelation_matrix` attribute and can remove this code:
{{{
try:
return self._autocorrelation_matrix
except AttributeError:
pass
}}}
(similarly for the `linearly_approximation_matrix`).
Martin, will/can you be doing a review of the math parts?
--
Ticket URL: <http://trac.sagemath.org/ticket/20336#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
