#12121: floor/ceil can be very slow at integral values
-------------------------------------+-------------------------------------
Reporter: dsm | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Marc Mezzarobba
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/12121 | d53c406171d73a0138d25336732728b41409c8b9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mmezzarobba):
I fear I won't have time to review your new version in the next few days
at least, but from a quick look at it there are a lot of things I don't
understand. In no particular order:
* why do you make `maximum_bits` an `Integer`?
* what don't you like about `unique_integer()`?
* is it really better to have an absolute bound for the diameter that
makes us suspect we found an exact integer, rather than something that
depends on the precision?
* why do you insist on using `==` on symbolic expressions instead of
`is_trivial_zero()`?
* are you sure you want to raise an error when `maximum_bits` does not
suffice to conclude? this is a symbolic function that may be buried deep
in the middle of a symbolic expression; returning unevaluated seems more
reasonable to me...
* do we really need two loops that do essentially the same thing
(including raising errors with the exact same message)?
--
Ticket URL: <http://trac.sagemath.org/ticket/12121#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
