#20375: faster is_one for integer matrices
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/20375 | 6c69bd98125210db0e009630f353a9439657a0a3
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mmezzarobba):
Replying to [comment:3 vdelecroix]:
> Not sure. `fmpz_mat_is_zero` is also declared as `int`.
>
> Are we allowed to change `int -> bint` inside the `pxd` header?
I'm not sure I understand your question. In new bindings, as far as I
understand, it is always better to use `bint` for `int`s that actually
represent boolean values. And I think the only situation where
''changing'' an `int` to `bint` could break existing code is when the
nonzero return value standing for `True` is not 1 and said existing code
tests it with `== that_value` instead of `!= 0`.
--
Ticket URL: <http://trac.sagemath.org/ticket/20375#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
