#19457: Generator for full binary trees
-------------------------------------+-------------------------------------
Reporter: patxiku | Owner: patxiku
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: binary trees, | Merged in:
full | Reviewers: Travis Scrimshaw,
Authors: Adrien | Vincent Delecroix
Boussicault, Bérénice Delcroix- | Work issues:
Oger, Patxi Laborde-Zubieta | Commit:
Report Upstream: N/A | db680072fecf713753e1a9c1320477607408b940
Branch: | Stopgaps:
public/combinat/full_binary_trees-19457|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
I don't think the definition of `to_full` you give is correct: {{{Return
the minimal full binary tree that is strictly larger than ``self``.}}}
With this definition, I would expect
{{{
o o
/ / \
o --------> o o
\ / \
o o o
}}}
And moreover it is easy to see that, in general, there is no unique binary
tree strictly larger than a given one! Am I wrong? The only thing which
makes sense the explicit definition you gave after. But in that case I
would not use the name `to_full` for the method name (which should be
reservered for the minimal binary tree larger or equal to self).
You should not use {{{``self``}}} (with the quote) in the documentation.
In that form it explicitely refers to an argument of a function. And
{{{self}}} should not be considered as an argument since this is a method.
You are free to use {{{self}}} (in its standard english sense) or
something more explicit like {{{this tree}}}.
What is the point of defining locally a function `to_full_rec` which is
used only once in the code?
--
Ticket URL: <http://trac.sagemath.org/ticket/19457#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
