#19163: LatticePoset creation: Empty argument, better error reporting
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-7.1
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/latticeposet_creation__empty_argument__better_error_reporting|  
a60a36bd61d937ca05ebd2f791f8132368ccb83a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:27 jmantysalo]:
 > Replying to [comment:24 jmantysalo]:
 >
 > Just pinging for this question:
 >
 > > But then I guess that `LatticePoset(P)` could say "not a
 ''semi''lattice", assuming that I don't check the error string. Is that
 bad? Not that much, but...?

 Well, perhaps just have `x` and `y` be default to `None` in the exception
 `__init__`, but it contradicts your docstring for `LatticeError`.
 Moreover, I still think you should let that propagate up rather than
 creating a completely new error message.

--
Ticket URL: <http://trac.sagemath.org/ticket/19163#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to