#20435: factorisation of polynomials over integers has wrong parent
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  critical           |    Milestone:  sage-7.2
      Component:  algebra            |   Resolution:
       Keywords:  factor,            |    Merged in:
  polynomial, parent                 |    Reviewers:  Bruno Grenet
        Authors:  Frédéric Chapoton  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/20435       |  3e28bfc536ac1b69c365213f4ff385874b6aee1e
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bruno):

 * status:  needs_review => positive_review
 * reviewer:   => Bruno Grenet


Comment:

 Sorry for that! The correction looks good to me.

 P.S.: I suspected that using `f[0].change_ring(self._parent.base_ring())`
 would have been faster than the conversion `self._parent(f[0])` but it
 appears not to be the case!

--
Ticket URL: <http://trac.sagemath.org/ticket/20435#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to