#20201: Improving Efficiency of LinearCode.NearestNeighborDecoder method
-------------------------------------+-------------------------------------
Reporter: arpitdm | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.2
Component: coding theory | Resolution:
Keywords: beginner | Merged in:
Authors: Arpit Merchant | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/improving_efficiency_of_linearcode_nearestneighbordecoder_method|
9fcf54ddeae6ce3bf0815390caf4e2c24fcdd0aa
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dlucas):
Hello,
You have two choices here:
1) You rollback to the previous implementation using a for loop, but in
that case you get rid of anything related to iterators.
2) You stick to the idea using iterator, and in that case, you actually
use an iterator.
In your latest push, you removed the line creating the iterator, but kept
the try/except block which attempts to catch a `StopIteration`
exception... Which cannot occur, because there is no longer an iterator
available!
Pick the one you prefer, and change the rest of the code accordingly.
Another remark: if you think your push is ready for review, please set the
ticket to `needs_review` :)
Best,
David
--
Ticket URL: <http://trac.sagemath.org/ticket/20201#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
