#11187: Implementation of finite reflection groups
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:  tbd
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  combinatorics      |   Resolution:
       Keywords:  reflection group,  |    Merged in:
  days49, days64.5, days80           |    Reviewers:
        Authors:  Christian Stump    |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/11187       |  0db28d6c6e64818eb32fb9826ff7a41333c814d6
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by stumpc5):

 there are still a few doctest failures that need to be fixed:
 {{{
 stumpc5@findstat:~/web-findstat/sage-patchbot$ ./sage -tp 6 --long
 --optional=ccache,gap3,mpir,patchbot,python2,sage
 src/sage/combinat/root_system/coxeter_group.py
 too many failed tests, not using stored timings
 Running doctests with ID 2016-04-21-13-13-55-f420497c.
 Git branch: t/11187/public/11187
 Using --optional=ccache,gap3,mpir,patchbot,python2,sage
 Doctesting 1 file using 6 threads.
 sage -t --long src/sage/combinat/root_system/coxeter_group.py
 **********************************************************************
 File "src/sage/combinat/root_system/coxeter_group.py", line 205, in
 sage.combinat.root_system.coxeter_group.CoxeterGroupAsPermutationGroup.__init__
 Failed example:
     TestSuite(W).run()             # optional - gap3
 Expected nothing
 Got:
     Failure in _test_well_generated:
     Traceback (most recent call last):
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python2.7/site-packages/sage/misc/sage_unittest.py",
 line 283, in run
         test_method(tester = tester)
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python2.7/site-
 packages/sage/categories/finite_complex_reflection_groups.py", line 628,
 in _test_well_generated
         tester.assertEqual(self.number_of_simple_reflections(),
 self.rank())
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python/unittest/case.py", line 515, in assertEqual
         assertion_func(first, second, msg=msg)
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python/unittest/case.py", line 508, in _baseAssertEqual
         raise self.failureException(msg)
     AssertionError: 3 != 27
     ------------------------------------------------------------
     The following tests failed: _test_well_generated
 **********************************************************************
 File "src/sage/combinat/root_system/coxeter_group.py", line 231, in
 
sage.combinat.root_system.coxeter_group.CoxeterGroupAsPermutationGroup._element_class
 Failed example:
     W._element_class() is W.element_class                      # optional
 - gap3
 Exception raised:
     Traceback (most recent call last):
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python2.7/site-packages/sage/doctest/forker.py", line
 496, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/srv/data/findstat.imp.fu-berlin.de/sage-
 patchbot/local/lib/python2.7/site-packages/sage/doctest/forker.py", line
 858, in compile_and_execute
         exec(compiled, globs)
       File "<doctest
 
sage.combinat.root_system.coxeter_group.CoxeterGroupAsPermutationGroup._element_class[1]>",
 line 1, in <module>
         W._element_class() is W.element_class                      #
 optional - gap3
       File "sage/structure/parent.pyx", line 854, in
 sage.structure.parent.Parent.__getattr__ (/srv/data/findstat.imp.fu-
 berlin.de/sage-patchbot/src/build/cythonized/sage/structure/parent.c:8083)
         attr = getattr_from_other_class(self, self._category.parent_class,
 name)
       File "sage/structure/misc.pyx", line 253, in
 sage.structure.misc.getattr_from_other_class (/srv/data/findstat.imp.fu-
 berlin.de/sage-patchbot/src/build/cythonized/sage/structure/misc.c:1763)
         raise dummy_attribute_error
     AttributeError: 'CoxeterMatrixGroup_with_category' object has no
 attribute '_element_class'
 **********************************************************************
 2 items had failures:
    1 of   4 in
 sage.combinat.root_system.coxeter_group.CoxeterGroupAsPermutationGroup.__init__
    1 of   3 in
 
sage.combinat.root_system.coxeter_group.CoxeterGroupAsPermutationGroup._element_class
     [54 tests, 2 failures, 10.25 s]
 ----------------------------------------------------------------------
 sage -t --long src/sage/combinat/root_system/coxeter_group.py  # 2
 doctests failed
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/11187#comment:250>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to