#7124: affine cipher and its cryptanalysis
----------------------------+-----------------------------------------------
   Reporter:  mvngu         |       Owner:  somebody       
       Type:  enhancement   |      Status:  needs_work     
   Priority:  major         |   Milestone:  sage-4.2       
  Component:  cryptography  |    Keywords:  affine cipher  
Work_issues:                |      Author:  Minh Van Nguyen
   Reviewer:                |      Merged:                 
----------------------------+-----------------------------------------------
Changes (by rbeezer):

  * status:  needs_review => needs_work


Comment:

 Minh,

 Some specific comments:

 1.  In {{{AffineCryptoSystem}}} there are comments about the list L which
 can probably be deleted.

 2.  In {{{__call__}}} the sanity check computes d and checks d == 1.  This
 could be removed if you trust your {{{_invertible}}} list.

 3.  Docstring on {{{inverse_key}}} has an odd test about euler_phi=12, a
 list of invertibles is computed, etc.  Not sure this is really germane.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7124#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to