#7236: Partitions cleanup (box => cell + indentation fix)
---------------------------------+------------------------------------------
Reporter: hivert | Owner: hivert
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.2
Component: combinatorics | Keywords: partitions cell, leg, arm, hook
Work_issues: | Author: Florent Hivert
Reviewer: Nicolas M. Thiéry | Merged:
---------------------------------+------------------------------------------
Changes (by nthiery):
* keywords: partitions cell => partitions cell, leg, arm, hook
* reviewer: => Nicolas M. Thiéry
* status: needs_review => needs_work
Old description:
> After a vote on {{{sage-combinat-devel}}}, see
> {{{
> http://groups.google.com/group/sage-combinat-
> devel/browse_thread/thread/bd6dd9b316236f91
> }}}
> it was decided that in a partition diagramm a square should be called a
> cell. The following patch implement this choice.
>
> I also take the occasion to fix an indentation problem which prevents
> some doc to be correctly typeset.
>
> Cheers,
>
> Florent
New description:
After a vote on {{{sage-combinat-devel}}}, see
{{{
http://groups.google.com/group/sage-combinat-
devel/browse_thread/thread/bd6dd9b316236f91
}}}
it was decided that in a partition diagram a square should be called a
cell instead of a box. The following patch implement this choice. In
particular, the following methods are renamed:
- add_box -> add_cell, remove_box -> remove_cell, boxes -> cells
I also took the occasion to fix an indentation problem which prevents some
doc to be correctly typeset, and to further rename:
- leg -> leg_length
- arm -> arm_length
- hook -> hook_length
Cheers,
Florent
--
Comment:
I just reviewed your patch. Positive review up to the following points:
- Specify in the definition of leg that this is in English notation
- Add deprecation hooks for all renamed methods
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7236#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
