#20501: Don't use today() for default arguments
----------------------------------+------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.2
Component: finance | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
----------------------------------+------------------------
Changes (by {'newvalue': u'Jeroen Demeyer', 'oldvalue': ''}):
* author: => Jeroen Demeyer
Old description:
> The file `src/sage/finance/stock.py` contains this line
> {{{
> def
> history(self,startdate='Jan+1,+1900',enddate=date.today().strftime("%b+%d,+%Y"),
> histperiod='daily'):
> }}}
> This causes the string with today's date to appear in `__doc__` which
> makes little sense. It would be better to use `None` as default argument
> and then change `None` to today in the function body.
New description:
The file `src/sage/finance/stock.py` contains this line
{{{
def
history(self,startdate='Jan+1,+1900',enddate=date.today().strftime("%b+%d,+%Y"),
histperiod='daily'):
}}}
The causes today's date to be hard-coded in the argspec and in the
`__doc__`, which makes little sense. It is better to use `None` as default
argument and then change `None` to today in the function body.
Note that doctests don't pass neither with or without this branch.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/20501#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
