#20512: 0 by 0 minor of a matrix should belong to the base ring
-------------------------------------+-------------------------------------
       Reporter:  kedlaya            |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.2
      Component:  linear algebra     |   Resolution:
       Keywords:  schemes,           |    Merged in:
  Jacobian, matrix, minors           |    Reviewers:
        Authors:  Kiran Kedlaya      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  06a432a988286bfae4a86e140e53022a9cbc4fc1
  u/kedlaya/jacobian_of_the_tautologous_subscheme_of_a_toric_variety_is_broken| 
    Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by kedlaya):

 Replying to [comment:5 chapoton]:
 > * doc is not formatted correctly, the line before the tests should end
 with `::` and be followed by a blank line
 >
 > * please also use {{{:trac:`20512`}}} instead of the bare {{{#20512}}}
 >
 > * you should rather use `.base_ring().one()` instead of
 `.base_ring()(1)`
 >
 All done. Also, I noticed that my fix wasn't actually sufficient: in
 `algebraic_scheme`, the `Jacobian_matrix()` method also needs to be forced
 to produce a matrix in the correct ring. The last commit does this.

--
Ticket URL: <http://trac.sagemath.org/ticket/20512#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to