#7246: digraph.DeBruijn in graph_generators
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.2
Component: graph theory | Keywords:
Work_issues: | Author:
Reviewer: | Merged:
----------------------------+-----------------------------------------------
Comment(by slabbe):
Dear Nathann, I just reviewed your code and made some modifications (see
patch). I mostly used some possibilities offered by the word code in sage
(e.g. * instead of concatenation and Words(n,1) for words of length one).
Tell me if you agree with those modifications.
The output when k=0 was broken (vertices of length one were appearing).
Although it could not be supported (return an error), I think it may be
defined using multiedges and hence the "Each vertex has exactly n incoming
and n outgoing edges" statement stays true. The wiki page doesn't talk
about k=0......
I am giving a positive review to your patch pending a solution for the
case k=0. Can you review my patch?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7246#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
