#20539: py3 print in interfaces folder
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_review
Type: | Milestone: sage-7.2
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Travis Scrimshaw
python3 | Work issues:
Keywords: | Commit:
Authors: | 0235c8649a4d945ea5a5094df4a49a5f197a9595
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
public/20539 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
LGTM except for the one thing:
{{{#!diff
@@ -277,7 +278,7 @@ class MaximaAbstract(ExtraTabCompletion, Interface):
['gcd', 'gcdex', 'gcfactor', 'gctime']
"""
if verbose:
- print s,
+ print(s)
sys.stdout.flush()
# in Maxima 5.19.1, apropos returns all commands that contain
# the given string, instead of all commands that start with
}}}
as it changes the output to have a new line. It's a marginal issue at
best, but I think it would be better to keep the same formatting as
before:
{{{#!python
print(s, end=" ")
}}}
Feel free to set a positive review with or without this change.
--
Ticket URL: <http://trac.sagemath.org/ticket/20539#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.