#20538: py3 print in tensor folder
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  chapoton               |       Status:  needs_review
           Type:         |    Milestone:  sage-7.2
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Travis Scrimshaw
  python3                |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  ec875acc5ac12457626ff550c6e511be537e18a8
  Frédéric Chapoton      |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/20538           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by tscrim):

 * reviewer:   => Travis Scrimshaw


Comment:

 I think it would be better to change the tests of the form
 {{{
 sage: for i in range(2):
 ....:     print w[i] == sum( phi.matrix()[i,j]*v[j] for j in range(3) ),
 ....:
 True True
 }}}
 to
 {{{
 sage: all(w[i] == sum(phi.matrix()[i,j]*v[j] for j in range(3)) for i in
 range(2))
 True
 }}}
 Also, could you add one more space in front of the lists with line breaks:
 {{{#!diff
  sage: list(c.index_generator())
  [(0, 0), (0, 1), (0, 2), (1, 0), (1, 1), (1, 2), (2, 0),
 -(2, 1), (2, 2)]
 + (2, 1), (2, 2)]
 }}}
 Otherwise LGTM. Thanks.

--
Ticket URL: <http://trac.sagemath.org/ticket/20538#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to