#20544: py3 print in matroids folder
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_review
Type: | Milestone: sage-7.2
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jori Mäntysalo
python3 | Work issues:
Keywords: | Commit:
Authors: | d863f8c68dbc473277b435e5beb842e9483071b2
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
public/20544 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by jmantysalo):
This is OK, and you can set this to ''positive_review'' without any
changes.
Usually you follow PEPs very strictly, so maybe you want to add spaces
after commas in
{{{
[len(x),len(y),len(x_i),len(y_i)]
}}}
(in two instances). In `src/sage/matroids/lean_matrix.pyx` there is a
commented out line
{{{
# print "row-scale: ", x, ", ", s
}}}
I suppose it can be just deleted. Grepping will be easier if "print " does
not match to a code line.
--
Ticket URL: <http://trac.sagemath.org/ticket/20544#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
