#18640: Topological manifolds: scalar fields
-------------------------------------+-------------------------------------
Reporter: egourgoulhon | Owner: egourgoulhon
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: geometry | Resolution:
Keywords: topological | Merged in:
manifolds | Reviewers: Travis Scrimshaw
Authors: Eric Gourgoulhon, | Work issues:
Michal Bejger | Commit:
Report Upstream: N/A | f11df50d2cd87172375db7d3c88e420ebb09d721
Branch: | Stopgaps:
public/manifolds/top_manif_scalar_fields|
Dependencies: #18529 |
-------------------------------------+-------------------------------------
Comment (by egourgoulhon):
Replying to [comment:37 tscrim]:
> Wee, finally had time to get it all done.
Thanks a lot for your work. It's nice to have the coordinate functions in
the parent/element scheme! In the above commit, I have simply changed the
category of the parent to `CommutativeAlgebras(SR)` and suppressed the
alias `is_commutative`. I have also added a few doctests and made some
slight improvements in the documentation.
>I started to use {{{``self``}}} because I recall less consensus on the
sage-devel thread; a good chuck of code uses it; if we add more code, it
becomes standard; and it simplifies a number of the doc sentences'
structure.
OK
>I did not implement as much coercion as might be possible (i.e.,
coordinate functions could coerce to the smallest chart they are defined
on), but the door is open to do so.
Indeed.
>I also added the global options and marked the tests in `utilities.py` as
`# known bug`.
Fine.
>So if my changes are good with you, then we can set this to a positive
review.
Please wait until tomorrow: I will check that the changes propagate nicely
to all tickets of #18528 (I've done it already for the next ticket
(#18725).
--
Ticket URL: <http://trac.sagemath.org/ticket/18640#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
