#20499: Graphs: docstring of _add_ conflicts with function
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  graph theory       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  David Coudert
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/graphs__docstring_of__add__conflicts_with_function|  
44e539e9c85793a3cfefaa8929a370ef28da5789
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):

 * status:  needs_work => needs_review


Comment:

 Replying to [comment:13 dcoudert]:

 I didi three changes as you suggested.

 > * I'm not fully aware of python3 syntax, but I suggest to avoid using
 `G._name = '%s disjoint_union %s'%(a, b)` and to prefer `G._name = '{}
 disjoint_union {}'.format(a, b)`. Well actually this is certainly more
 robust: `G.name('{} disjoint_union {}'.format(a, b))`.

 This will give an error: immutable graph can not change name. I suggest we
 keep this as it is now and think about this later.

--
Ticket URL: <http://trac.sagemath.org/ticket/20499#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to