#18725: Topological manifolds: morphisms
-------------------------------------+-------------------------------------
Reporter: egourgoulhon | Owner: egourgoulhon
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-7.2
Component: geometry | Resolution:
Keywords: topological | Merged in:
manifolds | Reviewers: Travis Scrimshaw
Authors: Eric Gourgoulhon, | Work issues:
Travis Scrimshaw | Commit:
Report Upstream: N/A | efcb618c969a0f060e59961be3ad2d913d6c7fc9
Branch: | Stopgaps:
public/manifolds/top_manif_morphisms|
Dependencies: #18640, #18175 |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Eric Gourgoulhon, Travis Scrimshaw', 'oldvalue':
u'Eric Gourgoulhon'}):
* status: needs_review => positive_review
* author: Eric Gourgoulhon => Eric Gourgoulhon, Travis Scrimshaw
Comment:
Replying to [comment:33 tscrim]:
> Okay, I made it through this ticket. I made a number of formatting
changes and little tweaks that I think improves the doc (including a few I
missed on the previous ticket). I also made aliases `*expression` of
`*expr` because it is good to be verbose, made some things
`@cached_method` rather than doing attribute caching, and used the
`@options` decorator for some `plot()` options. If you agree with my
changes, you can set a positive review.
Thank you very much for all the improvements. I've made a few checks on
the impact on the subsequent tickets in #18528 (especially regarding the
changes in `TopologicalManifoldHomset.__call__`); they all passed. So I am
setting the ticket to positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/18725#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
