#17229: Replace generator_cmp by generator_key and generator_reverse
-------------------------+-------------------------------------------------
Reporter: | Owner:
aapitzsch | Status: needs_review
Type: | Milestone: sage-7.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
python3 | Work issues:
Keywords: | Commit:
python3 | 971d3ad03eecfd3e597eac4f9914268b9cd514f2
Authors: André | Stopgaps:
Apitzsch |
Report Upstream: N/A |
Branch: |
public/17229 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by nthiery):
I just went through the diff, and it sounds reasonable (haven't checked
the details though).
Do we want to use the occasion to find better names for the options?
`generator_key` and `generator_reverse` can be confusing (e.g. in an
algebra one may think that this is about the algebra generators; also one
may believe that this is about recovering the index of a generator in its
family). Given that the sorting function is called `sorted_items` in
`CombinatorialFreeModule` and `IndexedFreeMonoid`, I would lean toward
something like `sort_key` and `sort_reverse`.
Tiny detail:
- in `filtered_algebras_with_basis.py`, sort_key would better be a method,
with doctest, as in `orlik_solomon.py`
--
Ticket URL: <http://trac.sagemath.org/ticket/17229#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
