#20650: Add is_polynomial and make_look_poly to projective morphism
-------------------------------------+-------------------------------------
Reporter: rlmiller | Owner: rlmiller
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-7.3
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Rebecca Lauren | Reviewers:
Miller | Work issues:
Report Upstream: N/A | Commit:
Branch: | 753f9ad95995d52a368f40acc0d639e7cf922e55
u/rlmiller/polynomials | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_work
Comment:
- The documentation does not build
{{{
[schemes ] /home/ben/sage/sage-test/local/lib/python2.7/site-
packages/sage/schemes/projective/projective_morphism.py:docstring of
sage.schemes.projective.projective_morphism.SchemeMorphism_polynomial_projective_space_finite_field.make_look_poly:13:
ERROR: Unexpected indentation.
Error building the documentation.
}}}
- Totally Rmified Fixed Point does not need initial caps.
- "x**n + a*x**(n-2) +...+c" should not be "
- the examples sage:: should only have one :.
- the doc tests pass, but only because the examples with :: are not being
run.
- formatting of the code needs some attention, such as spaces around =
- these two functions were added to the finite field section of polynomial
morphism. Should they work over other rings/fields as well?
- make_look_poly could use a better name. How about 'normal_form'? Since
it has only one keyword, you should use the keyword instead of the dict
kwds
--
Ticket URL: <http://trac.sagemath.org/ticket/20650#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
