#20669: LatticePoset: add function to get all sublattices
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  latticeposet       |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/all_sublattices       |  1bb87bd775eece24a586b9ccedb7dfd6ca0b5488
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:6 jmantysalo]:
 > Replying to [comment:5 tscrim]:
 > > Replying to [comment:4 jmantysalo]:
 > > > Of course I can change this to use backtracking, but... Then why not
 move this to static sparce graphs class, if we really want as fast code as
 possible?
 > >
 > > I have no inherent objects to this, but does the static sparse digraph
 code have the capacity to do the meet and joins?
 >
 > No, but that could be added. Or actually copied from current file. For
 Frattini sublattices that would actually make sense.

 However, meet and join doesn't quite make sense to have it there
 mathematically AFAIK. Although by cythonizing `hasse_diagram.py`, we
 should get most of possible speed without doing really much in the way of
 changes.

 > Basic questions about all reviews: 1) Is Sage better with this or
 without? 2) If with, is there some ''easy'' steps to make it still better?

 I am going to treat this as you telling me ''your'' process for reviewing.
 Otherwise I would take that a very insulting comment to me which you are
 telling me how to do ''my'' review.

--
Ticket URL: <http://trac.sagemath.org/ticket/20669#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to