#20629: some absolute imports in the rings folder
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_review
Type: | Milestone: sage-7.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jeroen Demeyer
python3 | Work issues:
Keywords: | Commit:
Authors: | b67f3d48a4fcbdb4e9a54385189e7d4334d88d0e
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
public/20629 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by tscrim):
Replying to [comment:24 chapoton]:
> Hmm, not sure I understand your conclusion. Did I do something "wrong" ?
Should we try to use `import foo` as much as possible, or the contrary ?
Well...there's my diagnosis of what might have caused the problem, and the
"pythonic" treatment. However, I disagree with it being the best way to
fix things.
> I just started wanting to convert to python3-compatible imports, and
then had to resolve
> a whole lot of circular imports. I did that by moving some imports
inside functions, instead
> of being on top of the files.
I think you did the right thing. Moreover, this is in agreement with what
we normally do in Sage. Does that clarify things?
--
Ticket URL: <http://trac.sagemath.org/ticket/20629#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
