#19939: Fixes and improvements to EuclideanRings.ParentMethods._test_quo_rem and
quo_rem for fields
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.3
      Component:  categories         |   Resolution:
       Keywords:  days70.5           |    Merged in:
        Authors:  Nicolas M. Thiéry  |    Reviewers:  Samuel Lelièvre
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/nthiery/fix_euclideanrings_parentmethods__test_quo_rem_to_use__not_r_is_zero____rather_than__r__0_|
  eda4420de3ebe869c55616c15eb44d94c73791b0
   Dependencies:  #19937             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work
 * milestone:  sage-7.1 => sage-7.3


Comment:

 I don't like this:
 {{{
 if not have_same_parent(self, other):
     other = self.parent()(other)
 }}}
 You should use coercion instead.

--
Ticket URL: <http://trac.sagemath.org/ticket/19939#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to